Added check for hide_admin_url config item

[Perturbatio]

Added check for display_admin_url config item which if not
set to 1 will prevent the server from revealing the admin URL
when the user visits the incorrect domain
(more useful in combination with the musthost config item)

This allows the user to lock the admin to a specific domain and
prevent the server revealing that domain to the public

[jcameron]

Looks like this new option makes the new behavior the default. Can you invert this so that Webmin behaves as it does now unless some new option is set (like hide_admin_url) ?

[Perturbatio]

I've updated the code now, do I need to resubmit the pull request?

[jcameron]

Looks better, but you should also remove the default setting from Perturbatio@4b59012

[Perturbatio]

That default setting should actually allow normal activity, I just thought it'd be more intuitive to a user when editing the config if the value was already there

[jcameron]

Wait, I think you got mixed up by my previous suggestion. The new config option should be called "hide_admin_url", and should have a default of zero - which means it could be left out of the default config block entirely.

[Perturbatio]

ok, updated again :)

On 24 October 2014 15:26, Jamie Cameron notifications@github.com wrote:

Wait, I think you got mixed up by my previous suggestion. The new config
option should be called "hide_admin_url", and should have a default of zero

• which means it could be left out of the default config block entirely.

—
Reply to this email directly or view it on GitHub
#175 (comment).

[jcameron]

Thanks!