Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor i18n files structure #40

Merged
merged 3 commits into from Nov 3, 2016
Merged

Refactor i18n files structure #40

merged 3 commits into from Nov 3, 2016

Conversation

amed
Copy link
Member

@amed amed commented Nov 2, 2016

Make Deutsch version is the default to be shown in index page

Make Deutsch version is the default to be shown in index page, so this closes #24.
@jhilden
Copy link

jhilden commented Nov 2, 2016

Deploy preview ready!

Built with commit 3ebc28b

https://deploy-preview-40--webmontag.netlify.com

@@ -17,7 +17,7 @@ html.no-js
= partial "shared/content/_event_box.slim",
locals: {locale: 'de', next_event: next_event, upcoming_events: upcoming_events}
#event-data
= partial "shared/content/_archive.slim", locals: {past_events: past_events, date_format: :day_month}
= partial "shared/content/_archive.slim", locals: {past_events: past_events, locale: 'de', date_format: :day_month}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hash wants to breathe

-events_grouped_by_year = past_events.group_by{ |event| event.date[0,4] }
-events_grouped_by_year.each do |year, events|
.year-wrap
h4
="#{year}"
ul
-events.each do |event|
-events.reverse.each do |event|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write a spec for this bugfix

Copy link
Member Author

@amed amed Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#41

[bug] Write spec for month arrangement.

#42)

Add a message to upcoming events section when upcoming events are not set yet, so this closes #37.
Change spec behaviour
@amed amed merged commit 27d99bd into master Nov 3, 2016
@amed amed deleted the i18n-refactor branch November 3, 2016 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants