Improvements #1
Merged
Improvements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| last_watched_submission_at: DateTime.now | ||
| ) | ||
|
|
||
| render json: User.current_watching_for(submission_id, current_user.id).to_a.map(&:nickname) |
There was a problem hiding this comment.
@lesniakania I think it's good to use pluck here http://api.rubyonrails.org/classes/ActiveRecord/Calculations.html#method-i-pluck
There was a problem hiding this comment.
Yes, you are right, changed.
|
@lesniakania please rebase and resolve conflicts |
Conflicts: app/controllers/api/submissions_controller.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactors.
Added authorization.
Added automatically rejecting mechanism.
Little improvements of calculating avg rate.
Small changes in views.
@szemek would you have some time tomorrow to look at this pull request together?
@gitjul would you have some time to help me testing if I didn't break anything?