Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data is stored uncompressed in zip file on saving #21

Closed
kossebau opened this issue Sep 25, 2013 · 0 comments
Closed

Data is stored uncompressed in zip file on saving #21

kossebau opened this issue Sep 25, 2013 · 0 comments
Labels
Milestone

Comments

@kossebau
Copy link
Contributor

@kossebau kossebau commented Sep 25, 2013

writeEntry(entry) in lib/core/Zip.js just writes the data uncompressed, ignoring the entry.compressed property

Resulting files seem okay from standard POV, but are quite large.

peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
@peitschie peitschie self-assigned this Sep 14, 2014
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 15, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 15, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 15, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 15, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 15, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 24, 2014
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Jul 13, 2015
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
@peitschie peitschie closed this in 435501c Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.