Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data is stored uncompressed in zip file on saving #21

Closed
kossebau opened this issue Sep 25, 2013 · 0 comments
Closed

Data is stored uncompressed in zip file on saving #21

kossebau opened this issue Sep 25, 2013 · 0 comments
Labels
enhancement
Milestone
WebODF 0.x.0

Comments

@kossebau
Copy link
Contributor

writeEntry(entry) in lib/core/Zip.js just writes the data uncompressed, ignoring the entry.compressed property

Resulting files seem okay from standard POV, but are quite large.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
36cce68 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
@peitschie peitschie mentioned this issue Sep 14, 2014
Closed
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
ecaf15a 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
91186f9 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
a1b28f9 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
e7db191 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
28faa0a 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been during compilation to include any 3rd party
dependencies.

Fixes webodf#21.
@peitschie peitschie self-assigned this Sep 14, 2014
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 14, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
6829493 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 15, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
462b0b4 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 15, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
cded965 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 15, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
7a569a3 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 15, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
a107df8 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 15, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
10e914b 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Sep 24, 2014
@peitschie
Replace existing zip implementation with jszip v2.4.0
3ab0786 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
peitschie added a commit to peitschie/WebODF that referenced this issue Jul 13, 2015
@peitschie
Replace existing zip implementation with jszip v2.4.0
84aa12f 
jszip has a much cleaner API than the existing RawDeflate version. In
addition, jszip supports creation of a compressed output stream.

As it's non-trivial to make jszip behave with closure compiler, a second
concat-only step has been added during compilation to include 3rd party
dependencies.

Fixes webodf#21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
WebODF 0.x.0
Development

Successfully merging a pull request may close this issue.

Replace existing zip implementation with jszip v2.4.0 peitschie/WebODF
2 participants
@peitschie @kossebau