Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If there is no <office:settings/> element, save an empty <office:document-settings/> element. #918

Merged
merged 1 commit into from Sep 11, 2015
Merged

If there is no <office:settings/> element, save an empty <office:document-settings/> element. #918

merged 1 commit into from Sep 11, 2015

Conversation

vandenoever
Copy link
Member

I ran the tests, but did not create a new test. Also tested in wodo editor.

@kogmbh-ci
Copy link

Build succeeded.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2413/

@kogmbh-ci
Copy link

Build failed.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2414/

@vandenoever vandenoever changed the title If settings.xml is not saved, it should not be in the manifest. If there is no <office:settings/> element, save an empty <office:document-settings/> element. Sep 10, 2015
@kogmbh-ci
Copy link

Build failed.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2415/

@kogmbh-ci
Copy link

Build failed.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2416/

@kogmbh-ci
Copy link

Build succeeded.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2417/

@adityab
Copy link
Member

adityab commented Sep 11, 2015

Please merge!

vandenoever added a commit that referenced this pull request Sep 11, 2015
@vandenoever
Merge pull request #918 from vandenoever/settings
999917d 
If there is no <office:settings/> element, save an empty <office:document-settings/> element.
@vandenoever vandenoever merged commit 999917d into webodf:master Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vandenoever @kogmbh-ci @adityab