Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Some Kind of Logging #4

Open
RobertFischer opened this issue Nov 21, 2014 · 2 comments
Open

Implement Some Kind of Logging #4

RobertFischer opened this issue Nov 21, 2014 · 2 comments

Comments

@RobertFischer
Copy link
Contributor

Either Winston or Debug.

@yashprit
Copy link

yashprit commented Mar 8, 2015

Why you want logging, I believe this will increase size of library and on top of this, configise don't really require logging, because we are mainly throwing error. If you still need this, I believe we should provide flag to user to enable or disable it.

@RobertFischer
Copy link
Contributor Author

It can be unclear why a particular key has a particular value, or even what
files Configise has loaded: we've had this problem on our own teams. This
is usually do to environment misconfigurations or user misunderstandings,
but there is no easy way to get feedback out of Configise to see what's
going on.

Logging should absolutely be opt-in. This is why I was looking at the
"debug" node module: https://www.npmjs.com/package/debug

~~ Robert.
yolamaverint, *v.; Latin, future perfect 2nd plural of "yolo", to only
live once; *"We will have only lived once!"

On Sun, Mar 8, 2015 at 3:17 PM, Yashprit notifications@github.com wrote:

Why you want logging, I believe this will increase size of library and on
top of this, configise don't really require logging, because we are
mainly throwing error. If you still need this, I believe we should provide
flag to user to enable or disable it.


Reply to this email directly or view it on GitHub
#4 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants