Fix object input field shortcut as callable

webonyx · Feb 5, 2021 · 4b5354e · 4b5354e
1 parent 115a20e
commit 4b5354e
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,9 @@ Deprecates:
 Refactoring:
 - Reify AST node types and remove unneeded nullability (#751)
 
+Fix:
+- Fix Input Object field shortcut definition with callable (#773)
+
 #### 14.4.1
 
 Fix:

diff --git a/src/Type/Definition/InputObjectType.php b/src/Type/Definition/InputObjectType.php
@@ -87,7 +87,7 @@ protected function initializeFields() : void
         }
 
         foreach ($fields as $name => $field) {
-            if ($field instanceof Type) {
+            if ($field instanceof Type || is_callable($field)) {
                 $field = ['type' => $field];
             }
             $field                      = new InputObjectField($field + ['name' => $name]);

diff --git a/tests/Type/DefinitionTest.php b/tests/Type/DefinitionTest.php
@@ -1608,6 +1608,23 @@ public function testAcceptsAnInputObjectTypeWithAFieldFunction() : void
         self::assertSame(Type::string(), $inputObjType->getField('f')->getType());
     }
 
+    /**
+     * @see it('accepts an Input Object type with a field type function')
+     */
+    public function testAcceptsAnInputObjectTypeWithAFieldTypeFunction() : void
+    {
+        $inputObjType = new InputObjectType([
+            'name'   => 'SomeInputObject',
+            'fields' => [
+                'f' => static function () : Type {
+                    return Type::string();
+                },
+            ],
+        ]);
+        $inputObjType->assertValid();
+        self::assertSame(Type::string(), $inputObjType->getField('f')->getType());
+    }
+
     /**
      * @see it('rejects an Input Object type with incorrect fields')
      */