Avoid eager-loading schema unnecessarily

[spawnia]

Resolves #1093
Resolves #954
Resolves #1137

[spawnia]

@vhenzl do you have an idea why the extended schema order differs from graphql-js and how we can fix it?

[vhenzl]

@spawnia, not sure what you mean. Different order of types in a printed schema? It would be #954.

[spawnia]

Some test cases are failing due to the order of the printed output, see https://github.com/webonyx/graphql-php/runs/6302953843?check_suite_focus=true

I went ahead and removed sorting from the SchemaPrinter, now some tests fail due to the changed output which should be trivial to fix.

[spawnia]

@vhenzl can you review this?

[ruudk]

@spawnia After using dev-master and dumping the schema, the types are no longer sorted A-Z.

Why are the types no longer sorted? This is super useful for diffing the persisted schema that is stored in git. We do that for example so that other projects can also pull in the schema.

When the types are now random or based on how they are discovered, it's gonna trigger more changes from time to time without no reason.

[spawnia]

The definition order of the schema is now kept. This is how the reference implementation does it now. We generally follow them, it makes maintenance much easier.

[ruudk]

What if we bring this back as an option to the SchemaPrinter?

SchemaPrinter::doPrint($schema, ['sort' => true])

It will then run this again:

$types = $schema->getTypeMap();
ksort($types);
$types = array_filter($types, $typeFilter);

[ruudk]

@spawnia Brought back the sorting of types as an option to the SchemaPrinter: #1152