Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI on PHP 8.2 #1252

Merged
merged 9 commits into from Nov 16, 2022
Merged

Run CI on PHP 8.2 #1252

merged 9 commits into from Nov 16, 2022

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Nov 16, 2022

No description provided.

@spawnia spawnia mentioned this pull request Nov 16, 2022
Closed
@spawnia
Copy link
Collaborator Author

spawnia commented Nov 16, 2022

Looks like PHPStan no longer accepts the @property annotations in interface NamedType without the presence of magic methods in PHP 8.2: https://phpstan.org/r/e79a1039-d9b7-447f-8ac9-8c7ea910cd6f

@simPod do you happen to know how we can deal with this?

@simPod
Copy link
Collaborator

simPod commented Nov 16, 2022

@spawnia only with AllowDynamicProperties

https://phpstan.org/r/d48f3a62-0cb0-44eb-9a31-90cc3a6f5d91

@spawnia spawnia marked this pull request as ready for review November 16, 2022 13:45
@spawnia spawnia merged commit cedab08 into master Nov 16, 2022
@spawnia spawnia deleted the php-8.2 branch November 16, 2022 13:45
@simPod simPod mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spawnia @simPod