Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deprecating input fields and arguments #1382

Merged

Conversation

TaProhm
Copy link
Contributor

@TaProhm TaProhm commented May 9, 2023

Resolves #110

@TaProhm TaProhm marked this pull request as ready for review May 9, 2023 23:45
@ruudk
Copy link
Contributor

ruudk commented May 10, 2023

@TaProhm thanks so much for this 🙏🏻

Copy link
Collaborator

@spawnia spawnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

src/Type/Introspection.php Outdated Show resolved Hide resolved
src/Type/Introspection.php Outdated Show resolved Hide resolved
tests/Type/DefinitionTest.php Outdated Show resolved Hide resolved
tests/Type/DefinitionTest.php Outdated Show resolved Hide resolved
tests/Type/DefinitionTest.php Outdated Show resolved Hide resolved
tests/Type/DirectiveTest.php Outdated Show resolved Hide resolved
tests/Type/DirectiveTest.php Outdated Show resolved Hide resolved
@TaProhm TaProhm force-pushed the allow-deprecating-input-fields-and-args branch from c77dd83 to 9e7e394 Compare May 10, 2023 19:08
@TaProhm
Copy link
Contributor Author

TaProhm commented May 10, 2023

@spawnia Thanks for your review, I've made corrections according to your suggestions and fixed the failing test.

src/Type/Introspection.php Outdated Show resolved Hide resolved
src/Type/Introspection.php Outdated Show resolved Hide resolved
@spawnia spawnia merged commit 8b37616 into webonyx:master May 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow deprecation of input values (arguments and input fields)
3 participants