Don't try parse value as string if it's already enum unit. PhpEnumType #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbka33
changed the title
|
Not sure I totally follow what you're up to, here, but if it makes any difference there's a PR pending that refactors the |
|
I'm sure there won't be any problems with this. I saw this PR. Only one method from the parent class is added here. I’m sure that the merger with your PR will take place without conflicts, but even if there are conflicts, it can be solved. |
spawnia
reviewed
Dec 5, 2023
| @@ -9,6 +9,10 @@ You can find and compare releases at the [GitHub release page](https://github.co | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Fix PhpEnumType parse value if it's already enum value https://github.com/webonyx/graphql-php/pull/1481 | |||
There was a problem hiding this comment.
Suggested change
| - Fix PhpEnumType parse value if it's already enum value https://github.com/webonyx/graphql-php/pull/1481 | |
| - Handle enum values in `PhpEnumType::parseValue()` https://github.com/webonyx/graphql-php/pull/1481 |
spawnia
reviewed
Dec 5, 2023
| 'extensions' => [ | ||
| 'debugMessage' => 'Expected a value of type SimpleEnum but received: "WRONG". Cannot serialize value as enum: "WRONG"', | ||
| 'trace' => [ | ||
| ['call' => 'GraphQL\Type\Definition\EnumType::serialize()'], | ||
| ['call' => 'GraphQL\Type\Definition\EnumType::serialize(\'WRONG\')'], |
There was a problem hiding this comment.
Unfortunately, this fails in lower PHP versions - see https://github.com/webonyx/graphql-php/actions/runs/6914711109/job/19325221423?pr=1481. Not sure why it failed for you anyways, we are testing on PHP 8.2 in CI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in subscriptions when an enum object is received instead of a string
I added a couple of tests to check how the value is parsed.
In addition, I fix a test that fails depending on the PHP version (
tests/Type/EnumTypeTest.php@testAllowsSimpleArrayAsValues). It might be worth using a check that does not include things that may change depending on the php version.All test passed. Tested with PHP 8.2.10 (cli) (built: Aug 31 2023 18:52:55) (NTS)
If we talk about the backward compatibility of these changes, then nothing should break.