+InlineFragment fields in ResolveInfo->getFieldSelection()

[rudiedirkx]

Background starting at #60 (comment)

[vladar]

Can you replace $fragmentType . ':' . $name with just $name? Otherwise it breaks the contract of this function (where you could just query result by field name).

[rudiedirkx]

Not really. The type condition is important, because implementor A and B could both query field X, but have different children, because they mean something else:

... on A {
  some {
    type
  }
}
... on B {
  some {
    kind
  }
}

some isn't in the interface, because they're a different kind of some, they just have the same name.

Would B win and overwrite A's type?

[vladar]

You are right. Need to think about it before merging

[rudiedirkx]

Maybe a new kind of nesting level instead of prefixing the key? Not very bc. Or returning a new, array accessible object with meta data like this? Could be bc, but might be overkill.

Also, I'm not sure this patch includes all cases: inline fragment, named fragment, inline fragment inside named fragment, etc. I've tried only 2 of many scenarios.

[coveralls]

Coverage decreased (-0.1%) to 88.58% when pulling 6e0904b on rudiedirkx:inlinefragment into 4a75bc6 on webonyx:master.

[rudiedirkx]

Have any brilliant solutions come up? With this, or something like it, I can make very efficient getters.

[vladar]

@rudiedirkx Not really. I guess good solution requires breaking change anyway.

I incline to deprecating this function and introducing new one wich will handle Inline fragments in more elegant way.

I guess I could merge this, but don't see much point since it will be deprecated anyway.

But technically it shouldn't block you. Just extract this piece of logic into your own utility function accepting ResolveInfo as argument and do the same.

Maybe eventually you will come up with brilliant solution and contribute it back %)

[rudiedirkx]

Sure, I could use my own method, but I rather use your shiny new very awesome new method. I'm very curious to see this more elegant way. Sneak preview anywhere? Create issue to track progress? You can close this PR.

[vladar]

@rudiedirkx See #65 to track this. Looking forward to hear your thoughts and ideas.