Fix double Error wrapping #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
approved these changes
Jun 29, 2020
|
Actually, since |
Not anymore, actually. Make sure your fork is up to date with the latest changes. |
|
Ah, right, I'm locally on 0.13 still. In that case we can keep this PR as is. |
|
Just realized I can't update to 0.14 yet due to overblog dependency. Is the v0.13 branch still maintained? Should I rebase this PR to target it instead? |
|
You can open another PR that targets https://github.com/webonyx/graphql-php/tree/0.13.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
$erroralready is an instance of the Error class this results in wrapping an Error by another Error which is useless and complicates error handling. In my opinion this should be fixed.