Fix the @var
type hint for various NodeList<Node>
usages.
#726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
= []
from a couple of usages, as this is now considered invalid typing.=== null
nowDiscussion:
With regard to
= []
and/or|null
/= null
, what approach would you want the library to take?If you want the library to start using
public NodeList $interfaces
, after PHP 7.4 becomes the minimum version, then attempting to access it directly would cause uninitialized errors unless it'spublic ?NodeList $interfaces = null
. Ensuring it's always initialized with the expected value would allow for fluid object access. At initial glance I don't see anywhere things are explicitly set to null (though I could be very wrong) so maintaining nullability doesn't seem necessary?Direction:
__construct()
method to do something like$this->interfaces = $this->interfaces ?? new NodeList([])
is one possibility.|null
and default to= null
?I'd lean toward ensuring they're initialized as NodeList, but could see going some other way depending on where you see the architecture going.
Thanks!