Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version query on old webOS #191

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

throwaway96
Copy link
Member

Description

On webOS 1, com.webos.service.systemservice doesn't exist. Instead it is named com.palm.systemservice. This alias still exists on webOS 8.

Presumably the existing code would not work on webOS 1.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run tests (npm run test & npm run e2e) that prove my fix is effective or that my feature works

webOS 1:

# luna-send-pub -n 1 'luna://com.palm.systemservice/osInfo/query' '{"parameters":["webos_manufacturing_version","webos_release"]}'
{ "webos_manufacturing_version": "05.05.70", "webos_release": "1.4.0", "returnValue": true }

webOS 8:

# luna-send-pub -n 1 'luna://com.palm.systemservice/osInfo/query' '{"parameters":["webos_manufacturing_version","webos_release"]}'
{"webos_release":"8.1.0","returnValue":true,"webos_manufacturing_version":"03.11.10"}

On webOS 1, com.webos.service.systemservice doesn't exist. Instead it is
named com.palm.systemservice. This alias still exists on webOS 8.
@mariotaku mariotaku merged commit 9861c34 into webosbrew:main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants