Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtc: add dump loc 1 quirk #107

Closed
wants to merge 1 commit into from

Conversation

asturel
Copy link

@asturel asturel commented Mar 12, 2023

On some tv-s (including my A1/lm21u/mt5889) dumped frames from scaler output affected by picture settings. Dumping from scaler input gives perfect color for builtin apps, however it breaks hdmi tonemapping afaik. (havent tried due to lack of hdmi device)

dump loc 2 (original):
image
dump loc 1:
image

original:
image

Credits to @sundermann for finding it.

@sundermann
Copy link
Contributor

Works on o22 for all content but the result is a little less impressive

@TBSniller
Copy link
Collaborator

TBSniller commented Mar 12, 2023

Thanks! :)
Would be great if you add your quirk info also to our Readme:

| VTCAPTURE | QUIRK_VTCAPTURE_FORCE_CAPTURE | Use of a custom kernel module for reenable capture in special situation | 0x100 |

@tuxuser is quirk counting 0x100, 0x200 for vtCapture in your interest?

@tuxuser
Copy link
Member

tuxuser commented Mar 13, 2023

Wouldn't it make sense to create an enum in tv-native-apis like so:

enum VT_CAPTURE_LOCATION {
  V4L2_EXT_CAPTURE_SCALER_INPUT = 1,
  V4L2_EXT_CAPTURE_SCALER_OUTPUT,
  V4L2_EXT_CAPTURE_DISPLAY_OUTPUT,
  V4L2_EXT_CAPTURE_BLENDED_OUTPUT,
  V4L2_EXT_CAPTURE_OSD_OUTPUT
};

And also rename (undocumented) dump location 1 to something like SCALER_INPUT ?

@tavalin
Copy link

tavalin commented Apr 9, 2023

Is there any documentation you can point me to compile/build this please?

@asturel
Copy link
Author

asturel commented Apr 9, 2023

Is there any documentation you can point me to compile/build this please?

download and setup buildroot from https://github.com/openlgtv/buildroot-nc4

mkdir -p ~/hyperion-webos/build
cd ~/hyperion-webos/build


. /opt/arm-webos-linux-gnueabi_sdk-buildroot/environment-setup

cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE=/opt/arm-webos-linux-gnueabi_sdk-buildroot/share/buildroot/toolchainfile.cmake ..

make hyperion-webos gm_backend halgal_backend dile_vt_backend vtcapture_backend 

ssh root@WEBOS_IP 'pkill hyperion-webos'
scp hyperion-webos *.so root@WEBOS_IP:/media/developer/apps/usr/palm/services/org.webosbrew.piccap.service/ 

you can download the build from my fork's action https://github.com/asturel/hyperion-webos/actions/runs/4403108956
and extract to /media/developer/apps/usr/palm/services/org.webosbrew.piccap.service

edit /media/developer/apps/usr/palm/services/org.webosbrew.piccap.service/config.json and add 512 to quirks

@webosbrew webosbrew deleted a comment from skraus-dev Jun 8, 2023
@satrik
Copy link

satrik commented Sep 4, 2023

@tuxuser @TBSniller is anyone working on this? Would be mindblowing if the capture is really a couple of frames ahead 🤯

@TBSniller
Copy link
Collaborator

Currently not. I think this got somehow stalled because of @tuxusers Not answered question.
@asturel What do you think about his idea?

@sundermann
Copy link
Contributor

superseded by #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants