Fix pixel byte order / color correctness for vtcapture #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundermann
commented
Apr 2, 2024
sundermann
force-pushed
the
vtcapture-colors
branch
from
813974b
to
f3cc9e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libyuv RGB24 actually means bgr byte order. Hyperion/HyperHDR expect pixels to be in rgb byte order.
This wasn't really an issue with UI layer captures as:
Capture using
FMT_ABGR(which is in fact ARGB) => ABGRToARGB (now the bytes are indeed bgr) => ARGBToRGB24 (reversing it again to get rgb again)Though in case for the captured content from vtcapture we assumed it to be NV21 (which is in fact NV12, confirmed using kernel sources) it kind of works because NV21 uses a similar but swapped layout. However we end up with swapped UV planes resulting in the colors being a little bit off. If NV12 is used then colors are almost perfect.
Thanks @asturel for investigating this