-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable automatic HDR and powerstate switching #87
Conversation
340ef25
to
3676f3f
Compare
3676f3f
to
5880999
Compare
Hey there, Thanks! |
5880999
to
5d33637
Compare
The title is a bit misleading as this PR was updated following the suggestions by @tuxuser. This is no longer for forcing the HDR state but rather adding the option to disable automatic HDR and screensaver switching. Regarding forcing the HDR state, I went another route in the meantime by adding tonemapping in hyperion-webos rather than relying on HyperHDR. |
This code is still missing the new arguments defined here: Line 77 in 5d33637
|
5d33637
to
1226385
Compare
Hey, Line 359 in 1226385
You also have to add these checks at legacy service register: Line 525 in 1226385
Thanks! |
And can you please lint your changes with clang?
We have added linting in latest unicapture branch PR before merging to main: https://github.com/webosbrew/hyperion-webos#code-style--linting |
68a679f
to
f1cd996
Compare
I have addressed your comments. Also the opposite was true: When HDR switching was off and a user enabled it, the callbacks would not have been registered. To fix this, I have completely removed the conditional checks on the service registration calls and instead moved to checking the current state inside the callbacks as you suggested. |
f1cd996
to
df2eaaf
Compare
Also thanks for this one! |
On my TV globally enabled HDR gives the best results even on SDR content. I assume that is because SDR content is converted to HDR internally resulting in washed out colors if HDR tone mapping is not enabled. This PR adds an quirk which can be set to force HDR state on all content.