Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUIRK: Fix quickstart on webOS 3.x TVs QUIRK_DILE_VT_DESTROY_ON_STOP #99

Closed
wants to merge 5 commits into from
Closed

QUIRK: Fix quickstart on webOS 3.x TVs QUIRK_DILE_VT_DESTROY_ON_STOP #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
322150a
Quirks: Add QUIRK_DILE_VT_DESTROY_ON_STOP
TBSniller Sep 29, 2022
46ba054
Fix DILE_START return value 0
TBSniller Sep 30, 2022
798ca6f
fix var declaration
TBSniller Oct 2, 2022
f4bd001
lint libdile_vt
TBSniller Oct 2, 2022
fc84577
Add QUIRK_DILE_VT_DESTROY_ON_STOP
TBSniller Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ Currently the following ones exist:
| DILE_VT | QUIRK_DILE_VT_CREATE_EX | Use `DILE_VT_CreateEx` instead of `DILE_VT_Create` | 0x1 |
| DILE_VT | QUIRK_DILE_VT_NO_FREEZE_CAPTURE | Do not freeze frame before capturing (higher fps) | 0x2 |
| DILE_VT | QUIRK_DILE_VT_DUMP_LOCATION_2 | (webOS 3.4) Use undocumented dump location 2 | 0x4 |
| DILE_VT | QUIRK_DILE_VT_DESTROY_ON_STOP | (webOS 3.4) Destroy driver on stop | 0x8 |
| VTCAPTURE | QUIRK_VTCAPTURE_FORCE_CAPTURE | Use of a custom kernel module for reenable capture in special situation | 0x100 |


Expand Down
68 changes: 53 additions & 15 deletions src/backends/libdile_vt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,24 @@ typedef struct _dile_vt_backend_state {
uint8_t*** vfbs;
int mem_fd;
bool no_freeze_to_acquire_frame;
bool create_ex;
bool dump_location_2;
bool destroy_on_stop;
int resolution_height;
int resolution_width;
int fps;
} dile_vt_backend_state_t;

int capture_init(cap_backend_config_t* config, void** state_p)
int dile_init(void* state);

int dile_init(void* state)
{
int ret = 0;
DILE_VT_HANDLE vth = NULL;

INFO("Capture start called.");
dile_vt_backend_state_t* this = (dile_vt_backend_state_t*)state;
DILE_VT_HANDLE vth = NULL;

if (HAS_QUIRK(config->quirks, QUIRK_DILE_VT_CREATE_EX)) {
if (this->create_ex) {
INFO("[QUIRK_DILE_VT_CREATE_EX]: Attempting DILE_VT_CreateEx...");
vth = DILE_VT_CreateEx(0, 1);
} else {
Expand All @@ -47,8 +55,6 @@ int capture_init(cap_backend_config_t* config, void** state_p)
return -1;
}

dile_vt_backend_state_t* this = calloc(1, sizeof(dile_vt_backend_state_t));
*state_p = this;
this->vth = vth;

DBG("Got DILE_VT context!");
Expand All @@ -65,7 +71,7 @@ int capture_init(cap_backend_config_t* config, void** state_p)
DBG("input deinterlace: %d; display deinterlace: %d", limitation.supportInputVideoDeInterlacing, limitation.supportDisplayVideoDeInterlacing);

DILE_VT_DUMP_LOCATION_TYPE_T dump_location;
if (HAS_QUIRK(config->quirks, QUIRK_DILE_VT_DUMP_LOCATION_2)) {
if (this->dump_location_2) {
// Quirk for WebOS 3.4 initialization
INFO("[QUIRK_DILE_VT_DUMP_LOCATION_2]: Attempting UNDOCUMENTED dump location 2...");
dump_location = 2;
Expand All @@ -89,7 +95,7 @@ int capture_init(cap_backend_config_t* config, void** state_p)
}
}

DILE_VT_RECT region = { 0, 0, config->resolution_width, config->resolution_height };
DILE_VT_RECT region = { 0, 0, this->resolution_width, this->resolution_height };

if (region.width < limitation.scaleDownLimitWidth || region.height < limitation.scaleDownLimitHeight) {
WARN("scaledown is limited to %dx%d while %dx%d has been chosen - there's a chance this will crash!", limitation.scaleDownLimitWidth, limitation.scaleDownLimitHeight, region.width, region.height);
Expand All @@ -109,7 +115,7 @@ int capture_init(cap_backend_config_t* config, void** state_p)
// (50/60fps). We don't have any better way of limiting FPS, so let's just
// average it out - if someone sets their preferred framerate to 30 and
// content was 50fps, we'll just end up feeding 25 frames per second.
this->output_state.framerate = config->fps == 0 ? 1 : 60 / config->fps;
this->output_state.framerate = this->fps == 0 ? 1 : 60 / this->fps;
INFO("[DILE_VT] framerate divider: %d", this->output_state.framerate);

DILE_VT_WaitVsync(vth, 0, 0);
Expand Down Expand Up @@ -186,11 +192,6 @@ int capture_init(cap_backend_config_t* config, void** state_p)
}
}

if (HAS_QUIRK(config->quirks, QUIRK_DILE_VT_NO_FREEZE_CAPTURE)) {
INFO("[QUIRK_DILE_VT_NO_FREEZE_CAPTURE]: Won't freeze for acquiring frames");
this->no_freeze_to_acquire_frame = true;
}

return 0;

err_mmap:
Expand All @@ -203,6 +204,32 @@ int capture_init(cap_backend_config_t* config, void** state_p)
return ret;
}

int capture_init(cap_backend_config_t* config, void** state_p)
{
INFO("Capture init called.");

int ret = 0;

dile_vt_backend_state_t* this = calloc(1, sizeof(dile_vt_backend_state_t));
*state_p = this;

this->create_ex = HAS_QUIRK(config->quirks, QUIRK_DILE_VT_CREATE_EX);
this->destroy_on_stop = HAS_QUIRK(config->quirks, QUIRK_DILE_VT_DESTROY_ON_STOP);

if (HAS_QUIRK(config->quirks, QUIRK_DILE_VT_NO_FREEZE_CAPTURE)) {
INFO("[QUIRK_DILE_VT_NO_FREEZE_CAPTURE]: Won't freeze for acquiring frames");
this->no_freeze_to_acquire_frame = true;
}

this->resolution_height = config->resolution_height;
this->resolution_width = config->resolution_width;
this->fps = config->fps;

ret = dile_init(this);

return ret;
}

int capture_cleanup(void* state)
{
dile_vt_backend_state_t* this = (dile_vt_backend_state_t*)state;
Expand All @@ -214,7 +241,12 @@ int capture_cleanup(void* state)
int capture_start(void* state)
{
dile_vt_backend_state_t* this = (dile_vt_backend_state_t*)state;
if (DILE_VT_Start(this->vth) != 0) {
int ret;
if ((ret = DILE_VT_Start(this->vth) != 0) && this->destroy_on_stop) {
// May need to reinit
dile_init(this);
return -99;
} else if (ret != 0) {
return -1;
}
return 0;
Expand All @@ -223,7 +255,13 @@ int capture_start(void* state)
int capture_terminate(void* state)
{
dile_vt_backend_state_t* this = (dile_vt_backend_state_t*)state;

DILE_VT_Stop(this->vth);

if (this->destroy_on_stop) {
DILE_VT_Destroy(this->vth);
}

return 0;
}

Expand Down
6 changes: 6 additions & 0 deletions src/quirks.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ enum CAPTURE_QUIRKS {
DILE_VT_SetVideoFrameOutputDeviceOutputRegion
*/
QUIRK_DILE_VT_DUMP_LOCATION_2 = 0x4,
/* (WebOS 3.x) Destroy DILE_VT driver on stop, so it can
be initialized again on TV standby awake. - TV will
kill hyperion-webos on standby, so driver is left in
memory
*/
QUIRK_DILE_VT_DESTROY_ON_STOP = 0x8,

// vtCapture
// Reenables video capture using custom kernel module
Expand Down
5 changes: 4 additions & 1 deletion src/unicapture.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,13 @@ void* unicapture_run(void* data)

if ((now - last_video_start) > 1000000 && video_capture != NULL && !this->video_capture_running) {
last_video_start = now;
int ret;
DBG("Attempting video capture init...");
if (video_capture->start(video_capture->state) == 0) {
if ((ret = video_capture->start(video_capture->state)) == 0) {
INFO("Video capture started");
this->video_capture_running = true;
} else if (ret == -99) {
this->video_capture_running = false;
}
}

Expand Down