Set surface ID with process id if it is 0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdapena, Could you take a look? It's to fix the browser visibility issue. As WebApp sets surface ID explicitly in WAM, it's for the browser. |
jdapena
requested changes
Nov 2, 2018
|
|
||
| // The window_manager on AGL handles surface_id 0 as an invalid id. | ||
| if (surface_id == 0) | ||
| surface_id = (int)getpid(); |
There was a problem hiding this comment.
Right! Thanks for the comment.
It sets surface ID with process ID if it has 0 as Window Manager handles surface ID 0 as an invalid ID. [SPEC-1889] Chromium is initially hidden when launched. https://jira.automotivelinux.org/browse/SPEC-1889
jkim-julie
force-pushed
the
surface_id
branch
from
cb21ec0
to
6e3bcfa
Compare
jdapena
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sets surface ID with process ID if it has 0 as Window Manager
handles surface ID 0 as an invalid ID.
[SPEC-1889] Chromium is initially hidden when launched.
https://jira.automotivelinux.org/browse/SPEC-1889