Skip to content
This repository has been archived by the owner on Mar 16, 2020. It is now read-only.

refactor: Apply webpack-defaults #51

Merged
merged 6 commits into from
Aug 12, 2017
Merged

refactor: Apply webpack-defaults #51

merged 6 commits into from
Aug 12, 2017

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Jul 16, 2017 •
edited
Loading

  • Apply webpack-defaults tooling updates
  • Apply webpack-defaults grammar updates
  • Apply webpack-defaults style updates
  • Convert existing tests to Jest from Mocha
  • Enable Appveyor service

Squashed commit message body for merge and 1.0.0 release

- refactor: Apply webpack-defaults

BREAKING CHANGE: Enforces `engines` of `"node": ">=4.3.0 < 5.0.0 || >= 5.10`
BREAKING CHANGE: Enforces `peerDependency` of `"webpack": "^2.0.0 || ^3.0.0`

Closes #34

@codecov
Copy link

codecov bot commented Jul 16, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6e0e866). Click here to learn what that means.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #51   +/-   ##
=========================================
  Coverage          ?   72.91%           
=========================================
  Files             ?        2           
  Lines             ?       48           
  Branches          ?       16           
=========================================
  Hits              ?       35           
  Misses            ?       12           
  Partials          ?        1
Impacted Files Coverage Δ
src/cjs.js 0% <0%> (ø)
src/index.js 74.46% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0e866...f06746e. Read the comment docs.

@joshwiens joshwiens self-assigned this Jul 16, 2017
boopathi
boopathi reviewed Jul 17, 2017
View reviewed changes
.babelrc Outdated
]
}
[
"env",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed

boopathi
boopathi reviewed Jul 19, 2017
View reviewed changes
package.json
],
"scripts": {
"build": "babel src --out-dir lib",
"build": "cross-env NODE_ENV=production babel src -d dist --ignore 'src/**/*.test.js'",
"watch": "babel src --out-dir lib --watch",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

{
  watch: "npm run build -- -w",
  start: "npm run watch",
}

? or remove watch.

Copy link
Member

@michael-ciniawsky michael-ciniawsky Jul 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start is the default and rm watch please 😛

boopathi
boopathi reviewed Jul 19, 2017
View reviewed changes
package.json Outdated
"mocha": "^3.4.1",
"nsp": "^2.6.3",
"pre-commit": "^1.2.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove precommit?. I don't like packages changing my .git directory. git encourages to commit fast. I see this as an anti-pattern. We have a CI setup and I'd rather catch lint errors there when missed than use something which when INSTALLED changes stuff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open an issue in webpack-defaults about this please, otherwise any update to webpack-defaults will add this back again and the boilerplate sync will be useless/cumbersome

michael-ciniawsky
michael-ciniawsky suggested changes Jul 19, 2017
View reviewed changes
package.json Outdated
"expect": "^1.20.2",
"jest": "^20.0.4",
"lint-staged": "^4.0.1",
"mocha": "^3.4.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- mocha

package.json Outdated
"eslint": "^4.1.1",
"eslint-config-webpack": "^1.2.5",
"eslint-plugin-import": "^2.7.0",
"expect": "^1.20.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- expect

package.json Outdated
"webpack": "^3.3.0",
"webpack-defaults": "^1.5.0"
},
"repository": "https://github.com/webpack-contrib/babili-webpack-plugin",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

+"repository": {
+    "type": "git",
+    "url": "https://github.com/webpack-contrib/babili-webpack-plugin.git"
+  },
+  "bugs": {
+    "url": "https://github.com/webpack-contrib/babili-webpack-plugin/issues"
+  },
+  "homepage": "https://github.com/webpack-contrib/babili-webpack-plugin",

@boopathi boopathi mentioned this pull request Jul 19, 2017
Closed
@joshwiens joshwiens closed this Aug 12, 2017
@joshwiens joshwiens reopened this Aug 12, 2017
@joshwiens joshwiens merged commit d0a724c into master Aug 12, 2017
@joshwiens joshwiens deleted the d3viant0ne-WebpackDefaults branch August 12, 2017 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@boopathi boopathi boopathi left review comments

@michael-ciniawsky michael-ciniawsky michael-ciniawsky requested changes

@hulkish hulkish hulkish approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

@joshwiens joshwiens

Labels
pr_action: Review semver: Major type: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joshwiens @hulkish @boopathi @alexander-akait @michael-ciniawsky