Skip to content
This repository has been archived by the owner on Mar 16, 2020. It is now read-only.

refactor(plugin): v1.0.0 #70

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor(plugin): v1.0.0 #70

wants to merge 3 commits into from

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Dec 5, 2017

  • Fixes for Webpack 4.x
  • Upgrades to webpack-defaults@2.0.0
  • Drops support for NodeJS 4.x
  • Sets minimum peerDep to Webpack 4.x
  • Adds schema enforcement

BREAKING CHANGE: Sets engines to "node": ">= 6.9.0 || >= 8.9.0"
BREAKING CHANGE: Drops support for Webpack v2.x
BREAKING CHANGE: Incorrect configuration options will now throw

@codecov
Copy link

codecov bot commented Dec 5, 2017

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #70   +/-   ##
====================================
  Coverage      84%   84%           
====================================
  Files           2     2           
  Lines          50    50           
  Branches       17    17           
====================================
  Hits           42    42           
  Misses          8     8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee6ca7...9b9abbd. Read the comment docs.

@joshwiens joshwiens self-assigned this Dec 5, 2017
@joshwiens joshwiens changed the title [WIP] Babel Minify Plugin v1 refactor: Babel Minify Plugin Webpack 4.x compatibility Dec 5, 2017
- Upgrades to `webpack-defaults@2.0.0`
- Drops support for `node =< v4.0.0`
- Sets the minimum `peerDependency` to `webpack >= 3.0.0`

BREAKING CHANGE: Sets `engines` to `"node": ">= 6.9.0 || >= 8.9.0"`
BREAKING CHANGE: Drops support for `webpack =< v2.0.0`
@@ -0,0 +1,9 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
   "type": "object",
   "properties": {
       "parserOpts": {
          "type":  "object"
        },
       "babel": {
          "typeof": "function"
        },
       "minifyPreset": {
          "typeof": "function"
        },
       "comments": {
          "instanceof": "RegExp"
        },
        "sourceMap": {
           "type":  "boolean"
        }
    },
    "additionalProperties": false
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But better with tests 😛

@michael-ciniawsky michael-ciniawsky changed the title refactor: Babel Minify Plugin Webpack 4.x compatibility refactor: webpack 4.x compatibility Dec 21, 2017
@michael-ciniawsky michael-ciniawsky changed the title refactor: webpack 4.x compatibility refactor(plugin): v1.0.0 Mar 19, 2018
@michael-ciniawsky michael-ciniawsky added this to the v1.0.0 milestone Mar 19, 2018
@ziogaschr
Copy link

Hello, thx for the great work on this PR. Any plans on when it will be merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants