Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

fix(index): add rootContext (this.rootContext) #70

Merged
merged 1 commit into from Feb 5, 2018
Merged

fix(index): add rootContext (this.rootContext) #70

merged 1 commit into from Feb 5, 2018

Conversation

statianzo
Copy link
Contributor

Webpack 4 removed this.options from loaders. The replacement for
this.options.context is this.rootContext.

this.options and this.rootContext
webpack 3 already deprecated this.options in the loader context. webpack 4 removes it now.

A lot of people are missing the this.options.context value now. It has been added as this.rootContext.

https://medium.com/webpack/webpack-4-migration-guide-for-plugins-loaders-20a79b927202

Fixes #69

Webpack 4 removed `this.options` from loaders. The replacement for
`this.options.context` is `this.rootContext`.
@jsf-clabot
Copy link

jsf-clabot commented Jan 30, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR

@alexander-akait alexander-akait added this to the v0.5.6 milestone Jan 31, 2018
@michael-ciniawsky michael-ciniawsky changed the title webpack 4: use loaderContext.rootContext fix(index): add rootContext (this.rootContext) Feb 5, 2018
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky
Copy link
Member

Released in v0.5.6 🎉 Thx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants