This repository has been archived by the owner on Oct 27, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 51
Always use absolute paths after reading from cache #83
Merged
mistic
merged 18 commits into
webpack-contrib:master
from
mistic:always-output-absolute-paths
Jun 25, 2019
Merged
Always use absolute paths after reading from cache #83
mistic
merged 18 commits into
webpack-contrib:master
from
mistic:always-output-absolute-paths
Jun 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests for this? I know it is not easy, but will be great have tests and note/todo in source code because for future developers/contributors it will be hard to understand why we did it and they can break it again
@evilebottnawi I've made the changes you request, could you review the PR please? |
alexander-akait
approved these changes
Jun 24, 2019
Can we open issue in https://github.com/webpack/memory-fs? |
@evilebottnawi I've opened an issue here #86 if u want to proceed with further investigation in the underlying dependencies |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want to use relative paths when writing to cache with a cacheContext.
In all the other cases, right after reading from cache, we should always use absolute paths or the webpack watch will break in very strange ways (probably because a bug in chokidar/watchpack). In that case, using a relative path with
this.fs.stat
(the fs cached version from the webpack compiler) would return stale metadata./CC @evilebottnawi