Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop node v12 #119

Closed
wants to merge 3 commits into from
Closed

build: drop node v12 #119

wants to merge 3 commits into from

Conversation

snitin315
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #119 (61f3ef3) into master (b7e6ff9) will not change coverage.
The diff coverage is n/a.

❗ Current head 61f3ef3 differs from pull request most recent head 5548529. Consider uploading reports for the commit 5548529 to get more accurate results

@@            Coverage Diff            @@
##            master      #119   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           18        18           
  Branches         2         2           
=========================================
  Hits            18        18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e6ff9...5548529. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to update deps too, same for other PRs

@snitin315
Copy link
Member Author

Yes, Let's update the deps too.

@snitin315
Copy link
Member Author

fixed in master

@snitin315 snitin315 closed this May 19, 2022
@snitin315 snitin315 deleted the drop-node-12 branch May 19, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants