Force compression when minRatio = 1 #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently documentation says if you set minRatio to 1, everything will be compressed. This actually isn't true. It still won't compress files that are LARGER than the original. This update does what the documentation says (rather than saying set minRatio to 99 or something)
|
|
|
Putting in an issue instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently documentation says if you set minRatio to 1, everything will be compressed. This actually isn't true. It still won't compress files that are LARGER than the original. This update does what the documentation says (rather than saying set minRatio to 99 or something)
This PR contains a:
Motivation / Use-Case
This change makes minRatio 1 actually compress all files.