Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chunks to include compressed files #186

Closed
wants to merge 1 commit into from

Conversation

xitter
Copy link

@xitter xitter commented Aug 28, 2020

Fixes: #185

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

While a new asset is being added, chunks should also be updated to indicate that they are also part of new asset.

Breaking Changes

None

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Aug 28, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #186 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   96.98%   97.04%   +0.05%     
==========================================
  Files           4        4              
  Lines         166      169       +3     
  Branches       46       47       +1     
==========================================
+ Hits          161      164       +3     
  Misses          3        3              
  Partials        2        2              
Impacted Files Coverage Δ
src/index.js 96.32% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ede778...78d206d. Read the comment docs.

@alexander-akait
Copy link
Member

#185 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chunk information in missing for compressed files
3 participants