Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: difference path separator for test on windows #353

Closed

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Mar 11, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Avoid difference path separator on widnows

fixes #348

After merge need merge #351 this too

Breaking Changes

Yes, now test should be use / separator instead \\, also tranformPath now get absolutePath with linux separators

Additional Info

No

@alexander-akait alexander-akait force-pushed the fix-incosistent-path-separator-in-logs branch 2 times, most recently from c6a75ce to 20f2992 Compare March 11, 2019 12:28
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@5b407f1). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #353   +/-   ##
=========================================
  Coverage          ?   59.01%           
=========================================
  Files             ?        8           
  Lines             ?      283           
  Branches          ?       70           
=========================================
  Hits              ?      167           
  Misses            ?      104           
  Partials          ?       12
Impacted Files Coverage Δ
src/processPattern.js 70.58% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b407f1...ed4ec5a. Read the comment docs.

@alexander-akait alexander-akait force-pushed the fix-incosistent-path-separator-in-logs branch from 20f2992 to ed4ec5a Compare March 11, 2019 12:42
@alexander-akait alexander-akait changed the title fix: difference path separator in logs on windows fix: difference path separator for test on windows Mar 11, 2019
@alexander-akait
Copy link
Member Author

Fixed

@alexander-akait alexander-akait deleted the fix-incosistent-path-separator-in-logs branch March 22, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows regex not passing group data
1 participant