Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - 388 : docs(readme): update ignore instructions #410

Merged
merged 3 commits into from
Dec 9, 2019

Conversation

jeffin143
Copy link
Contributor

@jeffin143 jeffin143 commented Nov 17, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #388

Breaking Changes

NA

Additional Info

NA

@jsf-clabot
Copy link

jsf-clabot commented Nov 17, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 17, 2019

Codecov Report

Merging #410 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #410   +/-   ##
======================================
  Coverage    94.8%   94.8%           
======================================
  Files           9       9           
  Lines         289     289           
  Branches       79      79           
======================================
  Hits          274     274           
  Misses         14      14           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45780be...ed81764. Read the comment docs.

Copy link

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions

👍

README.md Outdated Show resolved Hide resolved
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, please fix the typo problem

Co-Authored-By: Anix <anik220798@gmail.com>
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alexander-akait alexander-akait merged commit d155dd0 into webpack-contrib:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore a folder or a file
5 participants