Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the global context option #453

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

No need extra option (less options), you already have context option on pattern level

Breaking Changes

BREAKING CHANGE: the global context option was removed in favor the patten.context option

Additional Info

No

BREAKING CHANGE: the global `context` option was removed in favor the `patten.context` option
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #453 into master will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
- Coverage   94.59%   94.46%   -0.13%     
==========================================
  Files           9        9              
  Lines         259      253       -6     
  Branches       64       62       -2     
==========================================
- Hits          245      239       -6     
  Misses         13       13              
  Partials        1        1              
Impacted Files Coverage Δ
src/preProcessPattern.js 97.40% <ø> (ø)
src/index.js 94.73% <100.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6da280...7d039d4. Read the comment docs.

@alexander-akait alexander-akait merged commit 64b2e1a into master Apr 28, 2020
@alexander-akait alexander-akait deleted the refactor-remove-global-context-option branch April 28, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant