Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor tests #458

Merged
merged 3 commits into from
May 7, 2020
Merged

chore: refactor tests #458

merged 3 commits into from
May 7, 2020

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

remove mock compiler in favor webpack compiler

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #458 into master will increase coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   94.30%   94.71%   +0.40%     
==========================================
  Files           9        9              
  Lines         246      246              
  Branches       63       63              
==========================================
+ Hits          232      233       +1     
+ Misses         13       12       -1     
  Partials        1        1              
Impacted Files Coverage Δ
src/preProcessPattern.js 93.18% <0.00%> (-2.28%) ⬇️
src/index.js 100.00% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a728675...b8671bc. Read the comment docs.

@cap-Bernardito cap-Bernardito force-pushed the chore-refactor-tests branch 2 times, most recently from 82395f9 to 960958c Compare May 7, 2020 12:19
@cap-Bernardito cap-Bernardito marked this pull request as ready for review May 7, 2020 12:30
@alexander-akait alexander-akait merged commit 1e2f3a1 into master May 7, 2020
@alexander-akait alexander-akait deleted the chore-refactor-tests branch May 7, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants