Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to #globoptions #595

Conversation

mhxbe
Copy link
Contributor

@mhxbe mhxbe commented Mar 12, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

I was browsing the filter documentation as seen here where I noticed that the internal link to globOptions.ignore is broken due to a typo.

You can review the fix on my forked repo: https://github.com/mhxbe/copy-webpack-plugin/tree/bugfix/fix-broken-link-globoptions#filter

Breaking Changes

None.

Additional Info

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #595 (b3d6b6b) into master (01fa91b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   93.22%   93.22%           
=======================================
  Files           3        3           
  Lines         295      295           
  Branches       77       77           
=======================================
  Hits          275      275           
  Misses         20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01fa91b...b3d6b6b. Read the comment docs.

@mhxbe mhxbe force-pushed the bugfix/fix-broken-link-globoptions branch from d4a3fca to 89d0e04 Compare March 12, 2021 19:59
@mhxbe mhxbe force-pushed the bugfix/fix-broken-link-globoptions branch from 89d0e04 to b3d6b6b Compare March 12, 2021 20:01
@alexander-akait alexander-akait merged commit 4ca7f80 into webpack-contrib:master Mar 13, 2021
@alexander-akait
Copy link
Member

Thanks

@mhxbe mhxbe deleted the bugfix/fix-broken-link-globoptions branch March 13, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants