Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url('') is rewritten as require('./') #463

Closed
darrenscerri opened this issue Mar 22, 2017 · 3 comments
Closed

url('') is rewritten as require('./') #463

darrenscerri opened this issue Mar 22, 2017 · 3 comments

Comments

@darrenscerri
Copy link

What is the current behavior?
url('') is rewritten as require('./')

If the current behavior is a bug, please provide the steps to reproduce.
Simply specify a url('') rule in CSS.

What is the expected behavior?
url('') should not be allowed. Show a warning similar to webpack/webpack#2006
@darrenscerri darrenscerri mentioned this issue Mar 22, 2017
Closed
@alexander-akait
Copy link
Member

/cc @michael-ciniawsky what do you think about ignore empty url by default?

@michael-ciniawsky
Copy link
Member

Yep, also@ìmport/url() with protocol schema https://, but we need to clearify if that breaks current useage somehow (don't think so, but how knows for sure 😛)

alexander-akait pushed a commit to alexander-akait/css-loader that referenced this issue Apr 23, 2017
Fixed: don't handle empty import and url [webpack-contrib#463].
fa2d941
@alexander-akait alexander-akait mentioned this issue Apr 23, 2017
Merged
alexander-akait pushed a commit to alexander-akait/css-loader that referenced this issue Apr 23, 2017
Fixed: don't handle empty import and url [webpack-contrib#463].
b774b2f
alexander-akait pushed a commit to alexander-akait/css-loader that referenced this issue Apr 26, 2017
Fixed: don't handle empty import and url [webpack-contrib#463].
a62bb30
@alexander-akait
Copy link
Member

Done in #513

@michael-ciniawsky michael-ciniawsky removed this from Bug in Dashboard Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@darrenscerri @alexander-akait @michael-ciniawsky