chore: update comment #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
======================================
Coverage 98.6% 98.6%
======================================
Files 10 10
Lines 359 359
Branches 81 81
======================================
Hits 354 354
Misses 5 5
Continue to review full report at Codecov.
|
lib/processCss.js
Outdated
| @@ -102,6 +102,7 @@ var parserPlugin = postcss.plugin("css-loader-parser", function(options) { | |||
| break; | |||
| case "url": | |||
| if (options.url && !/^#/.test(item.url) && loaderUtils.isUrlRequest(item.url, options.root)) { | |||
| // Don't remove quotes around url when contain space | |||
michael-ciniawsky
changed the title
alexander-akait
force-pushed
the
just-fix-comment-in-code
branch
from
7514c0b
to
09013a2
Compare
michael-ciniawsky
changed the title
|
/cc @michael-ciniawsky i hate tabs 😄 done |
fahad19
added a commit
to fahad19/css-loader
that referenced
this pull request
Apr 24, 2017
* master: fix: case insensitivity of @import (webpack-contrib#514) chore: update comment (webpack-contrib#515) docs(README): improve importLoaders section and example (webpack-contrib#512) docs(README): fix link (webpack-contrib#508) docs(README): fix typo in example (webpack-contrib#507) docs(README): fix typo in maintainers link (webpack-contrib#505) fix: imported variables are replaced in exports if followed by a comma (webpack-contrib#504) docs(README): standardize (webpack-contrib#503) test: `charset` directive (webpack-contrib#502) fix: url with a trailing space is now handled correctly (webpack-contrib#494) fix: use `btoa` instead `Buffer` (webpack-contrib#501) test: add test for escaped characters (webpack-contrib#493) test: add tests for encoded svg data uri (webpack-contrib#492) test: add tests when css contain data uri and source maps are enabled (webpack-contrib#491) fix: loader now correctly handles `url` with space(s) (webpack-contrib#495)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Chore
Did you add tests for your changes?
not required
If relevant, did you update the README?
not required
Summary
Move comment on right place and fix typo
Other information
not required