This repository has been archived by the owner on Sep 28, 2020. It is now read-only.
Update readme (#129) #130
Merged
Update readme (#129) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoOx
suggested changes
Dec 7, 2016
| @@ -100,6 +100,21 @@ module.exports = { | |||
| } | |||
| ``` | |||
|
|
|||
| If you use `webpack 2.x`, you have to pass options object to `eslint-loader` by using `LoaderOptionsPlugin` ([webpack 2/docs](https://webpack.js.org/guides/migrating/#loaderoptionsplugin-context)). | |||
There was a problem hiding this comment.
This is not supposed to be necessary. eslint-loader already support options from query. Can you double check and remove this?
Add information about eslint behaviour when configFile is set directly.
|
@MoOx Sorry for that. I updated PR. I thought that LoaderOptionsPlugin is the only way to pass options to eslint-loader but you are right |
|
query can even be used in webpack 1 ;) |
deryni
added a commit
to deryni/eslint-loader
that referenced
this pull request
Dec 15, 2016
* MoOx/master: README: Add information about eslint behaviour when configFile is set directly (webpack-contrib#129) (webpack-contrib#130) Add clarifying note to README (webpack-contrib#127) Removed test.only so that all tests will run (webpack-contrib#125) 1.6.1 Fixed: multiples config per instance are now supported (webpack-contrib#123)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add information about eslint behaviour when configFile
is set directly.