Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

Update package.json for working with ESLint 5 #231

Closed
wants to merge 5 commits into from
Closed

Update package.json for working with ESLint 5 #231

wants to merge 5 commits into from

Conversation

Alex-Sokolov
Copy link
Contributor

ESLint 5 released, changed peerDependencies to higher version

@jsf-clabot
Copy link

jsf-clabot commented Jun 28, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@edmorley
Copy link
Contributor

Travis is failing:
https://travis-ci.org/webpack-contrib/eslint-loader/jobs/397734469#L593

@edmorley edmorley mentioned this pull request Jun 30, 2018
Closed
@edmorley
Copy link
Contributor

edmorley commented Jun 30, 2018 •
edited

Ah - the Travis failures seen here are unrelated to the ESLint 5 upgrade, but are instead due to a change in webpack output between webpack 4.11.1 and 4.12.0:
webpack/webpack#6542

...and this repository doesn't have a lockfile, so Travis is just pulling in latest (and there have been no landings on master since Feb, which is why it still looks green in Travis history).

The expected output just needs updating.

IMO this is a good example of why even libraries/consumable packages should still have lockfiles - and then use tools like https://renovatebot.com/ to automatically refresh them on a schedule - since it would give a failing "refresh lockfile" PR with easier to deduce cause.

@edmorley edmorley mentioned this pull request Jun 30, 2018
Closed
@edmorley
Copy link
Contributor

I've opened PR #235 to fix the unrelated test failures seen here.

@RinMinase RinMinase mentioned this pull request Jul 7, 2018
Closed
@edmorley @MoOx
Tests: Make formatter tests compatible with webpack >=4.12.0 (webpack…
afce811 
…-contrib#235)

Since the error output format changed in webpack/webpack#6542 to
prefix the error with the loader name. Now the tests use the original
`error.message` (which is unchanged), rather than the adjusted `message`.

Fixes webpack-contrib#233.
@MoOx
Copy link
Contributor

MoOx commented Jul 16, 2018

Can you rebase your pr on master so tests go green? thanks

@MoOx
Copy link
Contributor

MoOx commented Jul 16, 2018

Also please update dev deps so we are sure it's ok.

@Alex-Sokolov
Copy link
Contributor Author

@MoOx now ok?

@MoOx
Copy link
Contributor

MoOx commented Jul 17, 2018

No, sorry. You have merged back master which give a weird thing...
You need to update devDependencies to use latest eslint so we are sure tests are working. Nothing more.

@Alex-Sokolov
Copy link
Contributor Author

Closed for #240

@Alex-Sokolov Alex-Sokolov deleted the patch-1 branch July 17, 2018 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Alex-Sokolov @jsf-clabot @edmorley @MoOx @PoziWorld