This repository has been archived by the owner on Sep 28, 2020. It is now read-only.
Allow formatter to receive string (path) to file exporting formatter function
#247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
|
Thank you! |
edmorley
added a commit
to neutrinojs/neutrino
that referenced
this pull request
Sep 28, 2018
As of webpack-contrib/eslint-loader#247 `eslint-loader` now also supports the formatter being specified as a string, rather then only as a function. Passing as a string: * allows the formatter to work when using `thread-loader`, which has to serialize the loader options. * means we no longer need to manually specify `__expression`.
|
I'd like to strongly recommend to not depend on internal files of ESLint package. It's not a part of public API, so it can be changed in any patch releases. Use public API instead: https://eslint.org/docs/developer-guide/nodejs-api#clienginegetformatter |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address #246.
Thanks!
Incorporates changes from #239.