Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

Update dependencies. Relax eslint peer dependency to 0.x #32

Closed
wants to merge 1 commit into from
Closed

Conversation

nkbt
Copy link
Contributor

@nkbt nkbt commented Apr 12, 2015

I needed to upgrade to eslint 0.19 but ran into this issue.

20:51 $ npm install eslint-loader
npm WARN peerDependencies The peer dependency eslint@^0.18.0 included from eslint-loader will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm ERR! Darwin 14.1.0
npm ERR! argv "/Users/nkbt/.nvm/versions/io.js/v1.6.2/bin/iojs" "/Users/nkbt/.nvm/versions/io.js/v1.6.2/bin/npm" "install" "eslint-loader"
npm ERR! node v1.6.2
npm ERR! npm  v2.7.1
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package eslint does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer eslint-loader@0.9.0 wants eslint@^0.18.0

So apparently semver thinks that 0.18 is not compatible with 0.19, and when ^0.18 is used in peerDependencies main project must use 0.18 exclusively. So this dependency was relaxed to 0.x. After all, loader does not depend on eslint much so it should be ok and future-proof.

As soon as I updated this dependency, I decided to update other dependencies as well. Tests pass fine.

npm install nkbt/eslint-loader#esloader-19 worked without any issues as well.

PS: I did not update eslint-loader own version, so if you merge this one, you will need to update it and publish to npm.

@MoOx
Copy link
Contributor

MoOx commented Apr 13, 2015

Sorry but no.
See #17 (comment)
Also this loader doesn't work with something like 0.16 and below.

@MoOx MoOx closed this Apr 13, 2015
@nkbt
Copy link
Contributor Author

nkbt commented Apr 13, 2015

Makes sense. So just need an upgrade to 0.19 then...

@MoOx MoOx mentioned this pull request Apr 27, 2015
@nkbt nkbt mentioned this pull request Jun 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants