This repository has been archived by the owner on Sep 28, 2020. It is now read-only.
Update dependencies. Relax eslint peer dependency to 0.x #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to upgrade to eslint 0.19 but ran into this issue.
So apparently semver thinks that 0.18 is not compatible with 0.19, and when
^0.18
is used inpeerDependencies
main project must use 0.18 exclusively. So this dependency was relaxed to0.x
. After all, loader does not depend on eslint much so it should be ok and future-proof.As soon as I updated this dependency, I decided to update other dependencies as well. Tests pass fine.
npm install nkbt/eslint-loader#esloader-19
worked without any issues as well.PS: I did not update eslint-loader own version, so if you merge this one, you will need to update it and publish to npm.