Updates to ESLint 2.0.0 #81
Conversation
| @@ -16,14 +16,14 @@ | |||
| "index.js" | |||
| ], | |||
| "peerDependencies": { | |||
| "eslint": "^1.6.0" | |||
| "eslint": "^2.0.0" | |||
There was a problem hiding this comment.
Since there is no major change in the API, maybe we can scope 1.6 AND 2.0 ?
farneman
force-pushed
the
update-to-eslint-2
branch
5 times, most recently
from
b13781e
to
f492690
Compare
|
I updated the version specification and took another look at the test. It turns out I misunderstood what was going on in the test. However, without change that test fails so I need to sort out why and fix it correctly. |
farneman
force-pushed
the
update-to-eslint-2
branch
from
f492690
to
0e67e41
Compare
|
All tests are passing now. The skip ignored file warning conditional had to be updated due to a change at eslint/eslint@d43f26c#diff-3daec82d5218d64d8f2fed4d21f8e6ccR291. |
| @@ -30,7 +30,7 @@ function lint(input, config, webpack) { | |||
| res.warningCount === 1 && | |||
| res.results[0].messages[0] && | |||
| res.results[0].messages[0].message && | |||
| res.results[0].messages[0].message.indexOf(".eslintignore") > -1 && | |||
| res.results[0].messages[0].message.indexOf("ignore") > -1 && | |||
There was a problem hiding this comment.
if you try "ignore", no need for "no-ignore"?
farneman
force-pushed
the
update-to-eslint-2
branch
from
0e67e41
to
73b64a9
Compare
|
I've reduced the to string checks to just one check for more than one occurrence of |
| @@ -16,14 +16,14 @@ | |||
| "index.js" | |||
| ], | |||
| "peerDependencies": { | |||
| "eslint": "^1.6.0" | |||
| "eslint": ">=1.6.0 <2.1.0" | |||
There was a problem hiding this comment.
If api respect semver, should be <3.0.0 ?
farneman
force-pushed
the
update-to-eslint-2
branch
from
73b64a9
to
ee4d349
Compare
|
I updated the ESLint dependency scope. |
|
👍 |
|
👍 Waiting on this patch to merge to upgrade! |
|
Thanks! |
|
Released as 1.3.0 |
Updates ESLint dependencies to 2.0.0 and fixes some related test failures.
This fixes #79