Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use stillValidModule only lintDirtyModulesOnly is disabled #253

Merged
merged 2 commits into from
May 7, 2024
Merged

fix: use stillValidModule only lintDirtyModulesOnly is disabled #253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c437cb5
fix: use `stillValidModule` only `lintDirtyModulesOnly` is disabled
ricardogobbosouza May 3, 2024
706cd14
Merge branch 'master' into fix-still-valid-module
ricardogobbosouza May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ class ESLintWebpackPlugin {

// Add the file to be linted
compilation.hooks.succeedModule.tap(this.key, addFile);
compilation.hooks.stillValidModule.tap(this.key, addFile);

if (!this.options.lintDirtyModulesOnly) {
compilation.hooks.stillValidModule.tap(this.key, addFile);
}

/**
* @param {Module} module
Expand Down
Loading