build!: minimum supported Node.js version is 18.12.0
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
=======================================
Coverage 82.26% 82.26%
=======================================
Files 4 4
Lines 141 141
Branches 51 51
=======================================
Hits 116 116
Misses 16 16
Partials 9 9 ☔ View full report in Codecov by Sentry. |
snitin315
commented
Jan 16, 2024
| @@ -29,7 +29,7 @@ | |||
| "fix:js": "npm run lint:js -- --fix", | |||
| "fix:prettier": "npm run lint:prettier -- --write", | |||
| "fix": "npm-run-all -l fix:js fix:prettier", | |||
| "test:only": "cross-env NODE_ENV=test jest", | |||
| "test:only": "cross-env NODE_ENV=test NODE_OPTIONS=--experimental-vm-modules jest", | |||
There was a problem hiding this comment.
Tests were failing without this.
alexander-akait
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Update Node & deps.
Breaking Changes
Minimum supported Node.js version is 18.12.0
Additional Info
No