feat(expose-loader): support alternate options to handle exporting ESM (Harmony) modules #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Done. |
This was referenced Jul 11, 2019
|
Want this PR； |
sheijne
reviewed
Oct 11, 2019
Before this change the expose loader could only handle exposing the one thing exported from module.exports. This is great for modules that are written using RJS, but Harmony modules are an issue, since in the RJS representation of a Harmony module you might have named exports or the default export that you want to expose (without wanting to have to use .default every time). This adds an object syntax to the loader options which allows you to expose a single key of the RJS representation of the Harmony module instead of the whole thing. Fixes #56
A bug in lint-staged dependencies made using node 10 not possible when committing to this repository.
|
Ok this has been updated. There's one other chore added to this PR which is to upgrade one of the dependencies to allow node 10+ in lint-staged. Please let me know if this should be separated from this PR. |
patrick-mcdougle
changed the title
|
Is there any news? This is going to be very useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fixes #56
Fixes #82
Fixes #87
Breaking Changes
Old options behavior should still work, though, I don't have good test cases to prove that. Additional testing welcomed.
Additional Info
This will be my first PR to anything node / webpack so please be nice. 😆