[4.0.0-alpha.0] Cannot read property 'requestShortener' of undefined #722

machineloop · 2018-02-17T14:10:33Z

Using 4.0.0-alpha.0, Webpack 4.0.0-beta.1, Node 9.3.0 on macOS 10.12.6:

Thanks for the hard work on this! Thought I'd try out the new Alpha.0 with my build, looks like I may have found a bug. I'm getting the following error that clearly shows extract-text-webpack-plugin in the stack trace:

Fatal error: Cannot read property 'requestShortener' of undefined
TypeError: Cannot read property 'requestShortener' of undefined
    at ConcatenatedModule.source (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/webpack/lib/optimize/ConcatenatedModule.js:370:44)
    at Function.renderExtractedChunk (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/dist/index.js:115:38)
    at ExtractTextPlugin.extractedChunks.forEach.extractedChunk (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/dist/index.js:298:46)
    at Array.forEach (<anonymous>)
    at compilation.hooks.additionalAssets.tapAsync.assetCb (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/dist/index.js:286:25)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:7:1)
    at AsyncSeriesHook.lazyCompileHook [as _callAsync] (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/tapable/lib/Hook.js:35:21)
    at hooks.optimizeTree.callAsync.err (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/webpack/lib/Compilation.js:846:32)
    at _err0 (eval at create (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:11:1)
    at _async2.default.forEach.err (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/dist/index.js:281:11)
    at /home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:473:16
    at iteratorCallback (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:1050:13)
    at /home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:958:16
    at _async2.default.forEach.err (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/dist/index.js:259:13)
    at /home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:473:16
    at iteratorCallback (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:1050:13)
    at /home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:958:16
    at _async2.default.forEach (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/dist/index.js:253:20)
    at /home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:3096:16
    at eachOfArrayLike (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:1055:9)
    at eachOf (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:1103:5)
    at Object.eachLimit (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:3158:5)
    at _async2.default.forEach (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/dist/index.js:214:27)
    at /home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:3096:16
    at eachOfArrayLike (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:1055:9)
    at eachOf (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:1103:5)
    at Object.eachLimit (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:3158:5)
    at compilation.hooks.optimizeTree.tapAsync (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/extract-text-webpack-plugin/dist/index.js:208:25)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:7:1)
    at AsyncSeriesHook.lazyCompileHook [as _callAsync] (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/tapable/lib/Hook.js:35:21)
    at Compilation.seal (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/webpack/lib/Compilation.js:789:27)
    at hooks.make.callAsync.err (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/webpack/lib/Compiler.js:446:17)
    at _done (eval at create (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:9:1)
    at _err332 (eval at create (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:4004:22)
    at _addModuleChain (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/webpack/lib/Compilation.js:672:11)
    at processModuleDependencies.err (/home/app-user/agent/work/841aaf28d3ac9e7f/node_modules/webpack/lib/Compilation.js:614:8)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)
Task 'webpack:production' took 38925ms

Not sure what the best way is to create a minimal project showing issue. Happy to follow-up with more info... Thanks!

The text was updated successfully, but these errors were encountered:

michael-ciniawsky · 2018-02-17T17:47:12Z

For reference https://github.com/webpack/webpack/blob/master/lib/optimize/ConcatenatedModule.js#L370

TheLarkInn · 2018-02-20T17:32:18Z

Do you think you could reduce this to a minimal reproduction in a repository? This would help us significantly solve this.

circlingthesun · 2018-02-25T14:24:28Z

Well, it's calling chunkModule.source() (here: https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/v4.0.0-alpha.0/src/index.js#L94) without any parameters (see: https://github.com/webpack/webpack/blob/master/lib/optimize/ConcatenatedModule.js#L437)

phaistonian · 2018-02-26T09:07:08Z

The visual way - in case it helps any more.

peter-mouland · 2018-02-26T21:07:24Z

I can reproduce but only when my webpack config mode is set to production. I also noticed my old code had:

System.import('./app/utils/analytics').then((analytics) => analytics.init());

Please correct me if I am wrong, but I think system.import is deprecated and we should now be using import(). anyway, I commented out the offending line and everything is now dandy.

also, I had a number of plugins, and when I removed ExtractTextPlugin the error also went with it (i.e. i still had system.import in my code)

I was using "extract-text-webpack-plugin": "^4.0.0-alpha.0",

note: the reduced test case did not import any less/scss/css

Hope this helps.

peter-mouland · 2018-02-26T21:26:28Z

test case

// src/entry.js
  System.import('./app/utils/analytics').then((analytics) => analytics.init());
  console.log('test case');

// webpack.config.js
const ExtractTextPlugin = require('extract-text-webpack-plugin');

module.exports = {
  mode: 'production',
  entry: {
    app: ['./src/entry.js']
  },
  plugins: [
    new ExtractTextPlugin('[name].css'),
  ],
};

The above give an the error. The error can be resolved by either:

remove the use of System.import from entry.js
remove the use of new ExtractTextPlugin('[name].css'), from webpack config

circlingthesun · 2018-02-26T21:42:31Z

I'm not using System.import (at least not directly) and I'm still experiencing this issue.

peter-mouland · 2018-02-26T21:47:18Z

are you using ExtractTextPlugin?
do you think you could try to reproduce a minimal test case as I've done above to help narrow down your problem code?

circlingthesun · 2018-02-26T23:29:34Z

@peter-mouland I tried to reproduce it with a minimal example, but have not been able to. I can't even make it choke on System.import.

DNLHC · 2018-02-27T00:03:57Z

Seems like it breaks with any dynamic imports not just System.import
I have several dynamic imports

const Contacts = () => import('./contacts' /* webpackChunkName: "contacts" */);

after changing it to

import Contacts from './contacts';

everything builds fine

andybarron · 2018-02-27T07:37:28Z

Confirming the above comment - changing ES async imports to standard ES imports fixes this.

andybarron · 2018-02-27T07:40:53Z

Additionally, I can confirm that removing extract-text-webpack-plugin from my webpack.config.js fixes the issue.

circlingthesun · 2018-02-27T23:07:26Z

@TheLarkInn I've systematically hollowed out a project and ended up with this minimal reproduction: https://github.com/circlingthesun/extract-text-webpack-plugin-bug

michael-ciniawsky · 2018-02-28T02:58:26Z

Released in v4.0.0-beta.0 🎉

peter-mouland · 2018-02-28T08:52:45Z

that commit looks like it should do the job 👍 I'll be able to test when i get back from work. thanks @michael-ciniawsky!

@circlingthesun looking at your reduced test case, your problem is the same as previously mentioned (i.e. dynamic imports) so you should be good to go also 🎉

my reduced test case above now certainly works 💃

circlingthesun · 2018-02-28T08:57:41Z

@peter-mouland looks like it works 👍

alexander-akait · 2018-02-28T09:45:12Z

Thanks everyone 👍

DotCoyote · 2018-03-01T14:02:17Z

Webpack: 4.0.1, extract-text-webpack-plugin: 4.0.0-alpha.0, Node 9.4.0

I still got that bug when I use dynamic imports like this:

const Contacts = () => import('./contacts' /* webpackChunkName: "contacts" */);

as it has to be used for https://router.vuejs.org/en/advanced/lazy-loading.html

DotCoyote · 2018-03-01T14:08:24Z

Sorry, missed the beta-release

michael-ciniawsky added type: Bug severity: 3 (broken) priority: 4 (important) labels Feb 17, 2018

michael-ciniawsky added this to the 4.0.0 milestone Feb 17, 2018

odinuge mentioned this issue Feb 25, 2018

[WIP] Webpack 4 webkom/lego-webapp#1144

Closed

tzimmermann mentioned this issue Feb 26, 2018

[4.0.0-alpha.0] Cannot read property 'moduleExports' of undefined #727

Closed

clarkdo mentioned this issue Feb 27, 2018

Add null check on requestShortener webpack/webpack#6597

Closed

Jessidhia mentioned this issue Feb 27, 2018

fix(index): don't crash with dynamic import() #728

Merged

alexander-akait closed this as completed Feb 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.0.0-alpha.0] Cannot read property 'requestShortener' of undefined #722

[4.0.0-alpha.0] Cannot read property 'requestShortener' of undefined #722

machineloop commented Feb 17, 2018 •

edited

Loading

michael-ciniawsky commented Feb 17, 2018

TheLarkInn commented Feb 20, 2018

circlingthesun commented Feb 25, 2018

phaistonian commented Feb 26, 2018

peter-mouland commented Feb 26, 2018 •

edited

Loading

peter-mouland commented Feb 26, 2018 •

edited

Loading

circlingthesun commented Feb 26, 2018

peter-mouland commented Feb 26, 2018

circlingthesun commented Feb 26, 2018

DNLHC commented Feb 27, 2018 •

edited

Loading

andybarron commented Feb 27, 2018

andybarron commented Feb 27, 2018

circlingthesun commented Feb 27, 2018

michael-ciniawsky commented Feb 28, 2018

peter-mouland commented Feb 28, 2018 •

edited

Loading

circlingthesun commented Feb 28, 2018

alexander-akait commented Feb 28, 2018

DotCoyote commented Mar 1, 2018 •

edited

Loading

DotCoyote commented Mar 1, 2018

[4.0.0-alpha.0] Cannot read property 'requestShortener' of undefined #722

[4.0.0-alpha.0] Cannot read property 'requestShortener' of undefined #722

Comments

machineloop commented Feb 17, 2018 • edited Loading

michael-ciniawsky commented Feb 17, 2018

TheLarkInn commented Feb 20, 2018

circlingthesun commented Feb 25, 2018

phaistonian commented Feb 26, 2018

peter-mouland commented Feb 26, 2018 • edited Loading

peter-mouland commented Feb 26, 2018 • edited Loading

test case

circlingthesun commented Feb 26, 2018

peter-mouland commented Feb 26, 2018

circlingthesun commented Feb 26, 2018

DNLHC commented Feb 27, 2018 • edited Loading

andybarron commented Feb 27, 2018

andybarron commented Feb 27, 2018

circlingthesun commented Feb 27, 2018

michael-ciniawsky commented Feb 28, 2018

peter-mouland commented Feb 28, 2018 • edited Loading

circlingthesun commented Feb 28, 2018

alexander-akait commented Feb 28, 2018

DotCoyote commented Mar 1, 2018 • edited Loading

DotCoyote commented Mar 1, 2018

machineloop commented Feb 17, 2018 •

edited

Loading

peter-mouland commented Feb 26, 2018 •

edited

Loading

peter-mouland commented Feb 26, 2018 •

edited

Loading

DNLHC commented Feb 27, 2018 •

edited

Loading

peter-mouland commented Feb 28, 2018 •

edited

Loading

DotCoyote commented Mar 1, 2018 •

edited

Loading