Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix: text.forEach is not a function #134

Closed
wants to merge 1 commit into from

Conversation

Ty3uK
Copy link

@Ty3uK Ty3uK commented Dec 3, 2015

@GreenGremlin
Copy link

For me, this was happening because I was using webpack-split-by-path and it was pulling css-loader out of the entry chunk. I had to tell webpack-split-by-path to ignore css-loader.

See my fix here: Module build failed: TypeError: text.forEach is not a function #131.

@Ty3uK
Copy link
Author

Ty3uK commented Dec 4, 2015

I was using split-by-name-webpack-plugin and with my config webpack pulling to another chunk only angular and it's libraries.

posgarou added a commit to posgarou/extract-text-webpack-plugin that referenced this pull request Feb 9, 2016
Use master but include fix from PR webpack-contrib#134
@bebraw
Copy link
Contributor

bebraw commented Jan 26, 2017

Can you rebase? This could really use a test.

@joshwiens joshwiens force-pushed the master branch 2 times, most recently from 664e78c to 76a171d Compare January 28, 2017 22:40
@bebraw bebraw added this to the 2.1 features/fixes milestone Jan 29, 2017
@jsf-clabot
Copy link

jsf-clabot commented Apr 13, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 13, 2017

Codecov Report

Merging #134 into master will decrease coverage by 0.22%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   90.38%   90.16%   -0.23%     
==========================================
  Files           6        6              
  Lines         364      366       +2     
  Branches       77       78       +1     
==========================================
+ Hits          329      330       +1     
- Misses         35       36       +1
Impacted Files Coverage Δ
loader.js 89.53% <50%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a284f3a...836de37. Read the comment docs.

@bebraw bebraw requested a review from joshwiens April 13, 2017 06:41
@bebraw
Copy link
Contributor

bebraw commented Apr 13, 2017

Any chance for a test?

@Ty3uK
Copy link
Author

Ty3uK commented Apr 13, 2017

Sorry, but i don't understand how i can test empty object into text variable and pass it through Code Coverage. Never worked with this stuff.

@michael-ciniawsky michael-ciniawsky changed the title Fixed up issue#110 fix: #110 Apr 22, 2017
@michael-ciniawsky michael-ciniawsky changed the title fix: #110 fix: text.forEach is not a function Apr 22, 2017
@michael-ciniawsky
Copy link
Member

@Ty3uK Please add a comment to the code, so I in case this causes any regressions I can revert it :) Could you at least manually test it a bit and report ?

Copy link
Member

@joshwiens joshwiens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the amount of effort going into getting testing up to snuff across the organization, i'm not inclined to accept anything that doesn't have a test case. In this case, both a positive & negative test given how clearly defined the issue is.

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Jul 7, 2017

We are getting close to a new major release and therefore I will close this for now, feel free to open a new PR, if you still get this regression with npm i -D extract-text-webpack-plugin@beta

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants