-
Notifications
You must be signed in to change notification settings - Fork 517
Conversation
For me, this was happening because I was using See my fix here: Module build failed: TypeError: text.forEach is not a function #131. |
I was using |
Use master but include fix from PR webpack-contrib#134
Can you rebase? This could really use a test. |
664e78c
to
76a171d
Compare
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 90.38% 90.16% -0.23%
==========================================
Files 6 6
Lines 364 366 +2
Branches 77 78 +1
==========================================
+ Hits 329 330 +1
- Misses 35 36 +1
Continue to review full report at Codecov.
|
Any chance for a test? |
Sorry, but i don't understand how i can test empty object into text variable and pass it through Code Coverage. Never worked with this stuff. |
@Ty3uK Please add a comment to the code, so I in case this causes any regressions I can revert it :) Could you at least manually test it a bit and report ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the amount of effort going into getting testing up to snuff across the organization, i'm not inclined to accept anything that doesn't have a test case. In this case, both a positive & negative test given how clearly defined the issue is.
We are getting close to a new major release and therefore I will close this for now, feel free to open a new PR, if you still get this regression with |
Fixed with code written by Cleod9