fix(package): update schema-utils v0.3.0...0.4.1 (dependencies)

[dinkzilla]

Issues

• Fixes for schema-utils validation errors not thrown properly #667

Notable Changes

This pull request properly catches and throws validation errors within schema-utils so that they appear appropriately in the console.

As an example, a validation error which used to read as follows

<project-path>\node_modules\schema-utils\dist\validateOptions.js:40
    throw new _ValidationError2.default(ajv.errors, name);
    ^

false

now reads e.g

Extract Text Plugin Invalid Options

options['sourceMap'] should NOT have additional properties

[jsf-clabot]

All committers have signed the CLA.

[joshwiens]

Test suite will need to be updated accordingly

[codecov]

Codecov Report

Merging #668 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #668   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files           7        7           
  Lines         303      303           
  Branches       68       68           
=======================================
  Hits          265      265           
  Misses         36       36           
  Partials        2        2

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3ba94...7d97a94. Read the comment docs.

[dinkzilla]

Based on conversation in the #667 thread with @michael-ciniawsky, The correct fix was actually to update to the newest version of schema-utils, which now logs errors to the console. I have updated this pull request accordingly. Schema-utils will now log the error to the console and then exit, which required updating the validation failure test.

[michael-ciniawsky]

I'm sry about this 😅 I should have taken a look sooner but could you add process.env.JEST = true on L3-4 instead so schema-utils will rethrow the {Error} instead of exiting while running tests ? The 'old' test should work then.

const err = () => new ExtractTextPlugin({ filename: 1 })

expect(err).toThrow()
// Test if we get the correct err.message
expect(err).toThrowErrorMatchingSnapshot()

[dinkzilla]

But in reality, doesn't it write to console and exit, not throw? My test was written to match that scenario.

The test you describe would essentially be "when in testing with a bad config, does it throw?" Unless I'm missing something, that doesn't seem like a very valuable test.

(Not sure why one of the checks is failing, I've been on holiday and but tests were passing on my computer before I left. Can look into this tomorrow, and will update based on your response.)

[michael-ciniawsky]

The test should be changed back, but please hold on for ~1-2 days we resolved this in webpack core (#6035) and schema-utils (#17)

[dinkzilla]

@michael-ciniawsky Can you explain why the test should be changed back? I am still confused about what it is testing.

[michael-ciniawsky]

It's tests for malformed options based on a JSON Schema and should work without the need to mock anything in the test, please revert the test changes and I will finally land this on master :)

[alexander-akait]

@dinkzilla friendly ping 👍

[dinkzilla]

You caught me, been busy and totally forgot this was out here. I'll try to get to it this weekend. Thanks for the ping @evilebottnawi

[michael-ciniawsky]

It's tests for malformed options based on a JSON Schema and should work without the need to mock anything in the test, please revert the test changes and I will finally land this on master :)

[michael-ciniawsky]

I will update it myself with the next patch release