fix(index): allow to override publicPath with an empty string (#145)

webpack-contrib · Apr 15, 2017 · 26ab81a · 26ab81a
1 parent 9afc205
commit 26ab81a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -61,7 +61,7 @@ module.exports = function(content) {
 	}
 
 	var publicPath = "__webpack_public_path__ + " + JSON.stringify(url);
-	if (config.publicPath) {
+	if (config.publicPath !== false) {
 		// support functions as publicPath to generate them dynamically
 		publicPath = JSON.stringify(
 			typeof config.publicPath === "function"

diff --git a/test/correct-filename.test.js b/test/correct-filename.test.js
@@ -92,6 +92,18 @@ describe("publicPath option", function() {
 			'module.exports = "http://cdn/81dc9bdb52d04dc20036dbd8313ed055.txt";'
 		);
 	});
+
+	it("should override public path when given empty string", function() {
+		run("file.txt", "publicPath=").result.should.be.eql(
+			'module.exports = "81dc9bdb52d04dc20036dbd8313ed055.txt";'
+		);
+	});
+
+	it("should use webpack public path when not set", function() {
+		run("file.txt").result.should.be.eql(
+			'module.exports = __webpack_public_path__ + "81dc9bdb52d04dc20036dbd8313ed055.txt";'
+		);
+	});
 });
 
 describe("useRelativePath option", function() {