Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack-dev-server utils path #166

Merged
merged 2 commits into from Sep 1, 2018

Conversation

daviferreira
Copy link
Contributor

Q A
Bug fix? no
Breaking change? yes
New feature? no
Deprecations? no
Tests added? no
Docs updated? no
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT

webpack-dev-server util directory was renamed to utils on v3.1.7

webpack/webpack-dev-server#1465

@jsf-clabot
Copy link

jsf-clabot commented Aug 30, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #166 into master will decrease coverage by 0.29%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #166     +/-   ##
=========================================
- Coverage   64.48%   64.18%   -0.3%     
=========================================
  Files           8        8             
  Lines         214      215      +1     
  Branches       53       53             
=========================================
  Hits          138      138             
- Misses         62       63      +1     
  Partials       14       14
Impacted Files Coverage Δ
tasks/webpack-dev-server.js 13.72% <0%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1162bec...05bafac. Read the comment docs.

@ghost
Copy link

ghost commented Aug 30, 2018

I would say it should try both paths. Its sad this change was done in a patch-version bump of webpack-dev-server

@TheSpyder
Copy link

The utils folder is private API, nobody should have any expectation of internal API compatibility. The moment you start doing require('package/<anything>') you're bypassing the main field in package.json and taking a risk.

I logged an issue with webpack-dev-server yesterday to check, and confirmed this - the recommendation to fix the error is to have a try/catch that supports both paths.
webpack/webpack-dev-server#1483

@danez danez merged commit 218f46b into webpack-contrib:master Sep 1, 2018
@danez
Copy link
Collaborator

danez commented Sep 1, 2018

Thanks.

@ghost
Copy link

ghost commented Sep 3, 2018

@TheSpyder You are right. The actual question is: What official API could this package use in order to prevent this from happening in the future. Seems to me that this fix going to break again, when someone decides to refactor webpack-dev-server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants