Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib/utils): move createLog && rename files #1465

Merged
merged 1 commit into from Aug 27, 2018

Conversation

michael-ciniawsky
Copy link
Member

Type

  • Refactor

Issues

  • None

SemVer

  • Patch

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #1465 into master will decrease coverage by 0.06%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
- Coverage   78.94%   78.88%   -0.07%     
==========================================
  Files           5        5              
  Lines         494      502       +8     
  Branches      161      164       +3     
==========================================
+ Hits          390      396       +6     
- Misses        104      106       +2
Impacted Files Coverage Δ
lib/utils/addEntries.js 100% <100%> (ø)
lib/Server.js 81.92% <100%> (ø) ⬆️
lib/utils/createDomain.js 87.5% <87.5%> (ø)
lib/utils/createLogger.js 88.88% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2220c4...1a7f77d. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge

@michael-ciniawsky
Copy link
Member Author

AppVeyor failures are expected atm, since there is no setup yet (appveyor.yml) yet (#1468)

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #1465 into master will decrease coverage by 0.03%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
- Coverage   75.58%   75.55%   -0.04%     
==========================================
  Files           8        8              
  Lines         680      679       -1     
==========================================
- Hits          514      513       -1     
  Misses        166      166
Impacted Files Coverage Δ
lib/Server.js 83.43% <100%> (ø) ⬆️
lib/utils/addEntries.js 100% <100%> (ø)
lib/utils/createDomain.js 100% <100%> (ø)
bin/webpack-dev-server.js 62.63% <100%> (ø) ⬆️
lib/utils/createLogger.js 87.5% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e1f0c1...c4e0073. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Dashboard
Refactor
Development

Successfully merging this pull request may close these issues.

None yet

2 participants