Skip to content

Commit

Permalink
chore: add node 17 in CI (#407)
Browse files Browse the repository at this point in the history
  • Loading branch information
anshumanv committed Oct 22, 2021
1 parent 2d89166 commit 2fca322
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Expand Up @@ -56,7 +56,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: [12.x, 14.x, 16.x]
node-version: [12.x, 14.x, 16.x, 17.x]
webpack-version: [latest]

runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion test/__snapshots__/loader.test.js.snap
Expand Up @@ -93,7 +93,7 @@ exports[`loader should work with "html-webpack-plugin" plugin: result 1`] = `
<script defer src=\\"http://example.com/main.js\\"></script></head>
<body>
<div>Text</div>
<img src=\\"http://example.com/09a1a1112c577c279435.png\\" alt=\\"image\\">
<img src=\\"http://example.com/7bc91c245a8a10a4.png\\" alt=\\"image\\">
</body>
</html>"
`;
Expand Down
1 change: 1 addition & 0 deletions test/helpers/getCompiler.js
Expand Up @@ -17,6 +17,7 @@ export default (fixture, loaderOptions = {}, config = {}) => {
publicPath: "/webpack/public/path/",
library: "___TEST___",
assetModuleFilename: "[name][ext]",
hashFunction: "xxhash64",
},
module: {
rules: [
Expand Down
1 change: 1 addition & 0 deletions test/loader.test.js
Expand Up @@ -195,6 +195,7 @@ describe("loader", () => {
{
output: {
publicPath: "http://example.com",
hashFunction: "xxhash64",
},
module: {
rules: [
Expand Down

0 comments on commit 2fca322

Please sign in to comment.