feat: add support for async functions to preprocessor option #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@EslamHiko Let's update documentation too |
README.md
Outdated
| | Name | Type | Default | Description | | ||
| | :---------------------------------: | :-------------------------: | :------------------------------------------: | :----------------------------------------------: | | ||
| | **[`attributes`](#attributes)** | `{Boolean\|Object}` | `true` | Enables/Disables attributes handling | | ||
| | **[`preprocessor`](#preprocessor)** | `{Function\|AsyncFunction}` | `undefined` | Allows pre-processing of content before handling | |
There was a problem hiding this comment.
No need AsyncFunction here
| }, | ||
| }; | ||
| ``` | ||
|
|
There was a problem hiding this comment.
No need AsyncFunction header, just add somehintg like that: You can use async function, for example:
README.md
Outdated
|
|
||
| You can set the `preprocessor` option as an Asynchronous Function (`AsyncFunction`) instance. | ||
| You can also set the `preprocessor` option as an Asynchronous Function (`async Function`) instance. | ||
| For example : |
README.md
Outdated
| #### `AsyncFunction` | ||
|
|
||
| You can set the `preprocessor` option as an Asynchronous Function (`AsyncFunction`) instance. | ||
| You can also set the `preprocessor` option as an Asynchronous Function (`async Function`) instance. |
There was a problem hiding this comment.
as an asynchronous function instance.
README.md
Outdated
| | **[`minimize`](#minimize)** | `{Boolean\|Object}` | `true` in production mode, otherwise `false` | Tell `html-loader` to minimize HTML | | ||
| | **[`esModule`](#esmodule)** | `{Boolean}` | `false` | Use ES modules syntax | | ||
| | **[`minimize`](#minimize)** | `{Boolean\|Object}` | `true` in production mode, otherwise `false` | Tell `html-loader` to minimize HTML | | ||
| | **[`esModule`](#esmodule)** | `{Boolean}` | `false` | Use ES modules syntax | |
There was a problem hiding this comment.
Why it is changed, if not new?
There was a problem hiding this comment.
Oh I added : in the last of --- under the description table which made the lint centralize the description 😅
alexander-akait
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #264
Breaking Changes
No
Additional Info